feat(sdk-core): add verification options for signing txHex #7164
+181
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadalfaiyazbitgo
force-pushed
the
WP-6188/add-sign-verification-options
branch
from
1285579 to
c4e79ce
Compare
mohammadalfaiyazbitgo
force-pushed
the
WP-6188/add-sign-verification-options
branch
from
c4e79ce to
fa8f983
Compare
mohammadalfaiyazbitgo
force-pushed
the
WP-6188/add-sign-verification-options
branch
from
fa8f983 to
cb4aa9f
Compare
margueriteblair
previously approved these changes
Oct 29, 2025
Marzooqa
previously approved these changes
Oct 29, 2025
OttoAllmendinger
requested changes
Oct 29, 2025
mohammadalfaiyazbitgo
dismissed stale reviews from Marzooqa and margueriteblair
via
951fbbc
mohammadalfaiyazbitgo
force-pushed
the
WP-6188/add-sign-verification-options
branch
from
cb4aa9f to
951fbbc
Compare
mohammadalfaiyazbitgo
requested review from
Marzooqa,
OttoAllmendinger and
margueriteblair
done. |
OttoAllmendinger
approved these changes
Oct 30, 2025
FloBitGo
approved these changes
Oct 30, 2025
Marzooqa
approved these changes
Oct 30, 2025
Yes, I tested build & signing a transaction on eth & btc hot wallets on test, and followed up with sending a transaction with 'sendMany' to make downstream functions didn't break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: WP-6188
Tested with BTC & ETH Hot Wallets.